Repository navigation
feat(desktop): remove close buttons from sidebar inline agent dropdown - #6144
Merged
Merged
Conversation
The agents hover card on the dashboard sidebar workspace row no longer offers a per-agent stop button or a 'Stop all agents' footer; rows are open-only with their status always visible. Deletes the now-orphaned useDashboardSidebarAgentKill hook.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe dashboard sidebar agents chip and hover row no longer support stopping agents. The chip displays the agent count directly, while each hover row displays its status without a stop button. The agent-kill hook and its re-export were removed. ChangesAgent sidebar controls
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThe PR makes the dashboard sidebar’s running-agents card open/navigate-only by removing individual and bulk stop controls.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The stop controls, associated pending state, and kill hook were removed consistently, while the card’s remaining display and navigation behavior stays intact and no references to the deleted module remain.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/DashboardSidebarAgentsChip.tsx | Removes bulk-stop behavior and pending UI state while preserving hover-card toggling and agent navigation. |
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentHoverRow/DashboardSidebarAgentHoverRow.tsx | Removes the per-agent stop control and keeps the status label permanently visible without altering row navigation. |
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/hooks/useDashboardSidebarAgentKill/useDashboardSidebarAgentKill.ts | Deletes the orphaned agent-kill hook after all of its consumers were removed. |
Reviews (1): Last reviewed commit: "feat(desktop): remove close buttons from..." | Re-trigger Greptile
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Architecture diagram
sequenceDiagram
participant User
participant Chip as DashboardSidebarAgentsChip
participant Card as HoverCardContent
participant Row as DashboardSidebarAgentHoverRow
participant Nav as Navigation (Router)
Note over Chip, Nav: Simplified Navigation-Only Flow
User->>Chip: Hover or Click Chip
Chip->>Chip: Calculate primary agent (priority + recency)
Chip->>Card: NEW: Open navigation card (no footer/stop actions)
loop For each running agent
Card->>Row: Render agent info
Row->>Row: CHANGED: Render static status label (always visible)
Note right of Row: No stop (X) button or hover-swap logic
end
User->>Row: Click Agent Row
Row->>Nav: navigateToV2Workspace(workspaceId, terminalId)
Nav-->>User: Navigate to Agent Terminal
opt CHANGED: Component Cleanup
Note over Chip, Row: Deleted useDashboardSidebarAgentKill hook
Note over Chip, Row: Removed isPending/spinner states
end
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDashboardSidebarAgentKillhook and the chip's kill-pending spinner state.How It Works
DashboardSidebarAgentHoverRowdrops the grid overlay that swapped status text and the × in one cell; the status label is now a plain always-visible span.DashboardSidebarAgentsChipdrops the separator + footer button,handleStopAll, and theisPendingplumbing (spinner,disabled,aria-busy) that only existed for the kill flow.Manual QA (CDP, end-to-end)
Verified in this workspace's dev desktop instance (Vite port 3765, CDP 9250, signed-in session with active org confirmed). Since the chip only renders with 2+ running agents, launched two Claude agents in a workspace via the real presets bar, then clicked the sidebar "✳ 2" chip with real mouse input.
Hover card open with an agent row hovered — no × on the row, no separator, no "Stop all agents" footer:
Full window for context:
DOM inspection of the open card confirms zero stop/close buttons. Chip open/close toggle and row click-through to the workspace still work (used them during capture).
Testing
bun run lint(clean)tsc --noEmitforapps/desktop(clean)Screenshots live on the
evidence/remove-agent-close-buttonbranch per the repo's evidence convention.Summary by cubic
Removed per‑agent stop buttons and the “Stop all agents” footer from the desktop sidebar agents hover card. The card is now navigation‑only: rows always show status, and the chip shows avatar + count.
useDashboardSidebarAgentKill.DashboardSidebarAgentsChipby dropping pending state, spinner, toasts, and disabled logic.DashboardSidebarAgentHoverRowto show a plain, always-visible status label (no hover swap or kill button).Written for commit f01ff5b. Summary will update on new commits.
Summary by CodeRabbit